[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...

2017-02-06 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r99588025 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -841,5 +841,6 @@ private[client] class Shim_v1_2 extends

[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...

2017-02-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r99585661 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -841,5 +841,6 @@ private[client] class Shim_v1_2 extends

[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...

2017-02-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r99585644 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -841,5 +841,6 @@ private[client] class Shim_v1_2 extends

[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...

2017-02-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r99585445 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -276,4 +276,4 @@ private[hive] object HiveShim {