[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-03-07 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r104861465 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala --- @@ -134,13 +134,20 @@ class Word2VecSuite extends SparkFunSuite with

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16811 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-03-06 Thread Krimit
Github user Krimit commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r104402251 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala --- @@ -134,13 +134,20 @@ class Word2VecSuite extends SparkFunSuite with

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-03-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r104330610 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala --- @@ -134,13 +134,20 @@ class Word2VecSuite extends SparkFunSuite with

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-02-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r103338261 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala --- @@ -144,6 +144,31 @@ class Word2VecSuite extends SparkFunSuite with

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-02-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r103338146 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala --- @@ -144,6 +144,31 @@ class Word2VecSuite extends SparkFunSuite with

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-02-06 Thread Krimit
Github user Krimit commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r99612768 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -232,19 +232,40 @@ class Word2VecModel private[ml] ( @Since("1.5.0")

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-02-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r99572391 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -232,19 +232,40 @@ class Word2VecModel private[ml] ( @Since("1.5.0")

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-02-05 Thread Krimit
GitHub user Krimit opened a pull request: https://github.com/apache/spark/pull/16811 [SPARK-17629][ML] methods to return synonyms directly ## What changes were proposed in this pull request? provide methods to return synonyms directly, without wrapping them in a dataframe