Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16933
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104798370
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,175 @@ class CollapseRepar
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104798255
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,175 @@ class CollapseRepar
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104798081
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,175 @@ class CollapseRepar
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104797868
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,175 @@ class CollapseRepar
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104786851
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,180 @@ class CollapseRepar
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104786298
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,180 @@ class CollapseRepa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104772991
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,180 @@ class CollapseRepar
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104772284
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,47 +32,180 @@ class CollapseRepar
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104556080
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -562,27 +562,37 @@ object CollapseProject extends Ru
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104543895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -562,27 +562,43 @@ object CollapseProject extends R
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104543920
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -562,27 +562,43 @@ object CollapseProject extends R
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104355455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -562,27 +562,43 @@ object CollapseProject extends Ru
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r104355337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -562,27 +562,43 @@ object CollapseProject extends Ru
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101911156
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -43,15 +55,44 @@ class CollapseRepar
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101351110
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,6 +32,18 @@ class CollapseRepar
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101350801
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -563,23 +563,27 @@ object CollapseProject extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101346606
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -43,15 +55,44 @@ class CollapseRepar
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101342124
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,6 +32,18 @@ class CollapseRepart
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101341551
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -563,23 +563,27 @@ object CollapseProject extends R
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101341238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -374,6 +374,9 @@ package object dsl {
case plan
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101219684
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -43,15 +55,44 @@ class CollapseRepa
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101218700
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -374,6 +374,9 @@ package object dsl {
case pla
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101218852
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -563,23 +563,27 @@ object CollapseProject extends
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101219386
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,6 +32,18 @@ class CollapseRepar
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101163037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -563,23 +563,27 @@ object CollapseProject extend
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16933
[SPARK-19601] [SQL] Fix CollapseRepartition rule to preserve
shuffle-enabled Repartition
### What changes were proposed in this pull request?
When users use the shuffle-enabled `repartition`
27 matches
Mail list logo
