[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105587493 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala --- @@ -90,16 +90,14 @@ trait FileFormat { * @param

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105552491 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -121,6 +121,20 @@ class FileScanRDD( next

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-12 Thread apurvis
Github user apurvis commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105552466 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -130,54 +144,35 @@ class FileScanRDD(

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105529164 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala --- @@ -90,16 +90,14 @@ trait FileFormat { * @param op

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105526137 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -44,7 +44,7 @@ case class PartitionedFile(

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105526080 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -130,54 +144,35 @@ class FileScanRDD(

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105525303 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -44,7 +44,7 @@ case class PartitionedFile( fi

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17253#discussion_r105525158 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -130,54 +144,35 @@ class FileScanRDD( /

[GitHub] spark pull request #17253: [SPARK-19916][SQL] simplify bad file handling

2017-03-10 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/17253 [SPARK-19916][SQL] simplify bad file handling ## What changes were proposed in this pull request? We should only have one centre place to try catch the exception for corrupted files.