[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-28 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108373968 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -289,6 +289,9 @@ abstract class QueryPlan[PlanType <: Query

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-28 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108373273 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -123,6 +136,31 @@ class JoinOptimizationSuit

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108224172 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -123,6 +136,31 @@ class JoinOptimizationSuit

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108222730 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -123,6 +136,31 @@ class JoinOptimizationSuit

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108220965 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -289,6 +289,9 @@ abstract class QueryPlan[PlanType <:

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108218188 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -123,6 +136,31 @@ class JoinOptimizationSuit

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108217534 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -289,6 +289,9 @@ abstract class QueryPlan[PlanType <: Query

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108209215 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -123,6 +136,31 @@ class JoinOptimizationSuit

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108208545 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -289,6 +289,9 @@ abstract class QueryPlan[PlanType <: Query

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108208611 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -90,6 +90,10 @@ trait PredicateHelper { * Ret

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108195342 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -90,6 +90,10 @@ trait PredicateHelper { * Ret

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108196677 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -123,6 +136,31 @@ class JoinOptimizationSuit

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108185240 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -289,6 +289,9 @@ abstract class QueryPlan[PlanType <: Query

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108116714 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -90,6 +90,7 @@ trait PredicateHelper { * Ret

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108104559 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -90,6 +90,7 @@ trait PredicateHelper { * Retu

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-27 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108103096 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -90,6 +90,7 @@ trait PredicateHelper { * Retu

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108101023 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -90,6 +90,7 @@ trait PredicateHelper { *

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Don't put predicate with IN su...

2017-03-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17428#discussion_r108086458 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -90,6 +90,7 @@ trait PredicateHelper { * Ret