[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110855845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala --- @@ -204,20 +204,19 @@ object JavaTypeInference { ty

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110855725 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala --- @@ -204,20 +204,19 @@ object JavaTypeInference {

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110853394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala --- @@ -204,20 +204,19 @@ object JavaTypeInference { ty

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17604#discussion_r110840736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -204,37 +204,37 @@ object ScalaReflection extends ScalaR

[GitHub] spark pull request #17604: [SPARK-20289][SQL] Use StaticInvoke to box primit...

2017-04-11 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/17604 [SPARK-20289][SQL] Use StaticInvoke to box primitive types ## What changes were proposed in this pull request? Dataset typed API currently uses NewInstance to box primitive types (i.e. calling the