[GitHub] spark pull request #17623: [SPARK-20292][SQL][WIP] Clean up string represent...

2017-04-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17623#discussion_r111525819 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -149,7 +149,7 @@ case class Cast(child: Expression, dataTy

[GitHub] spark pull request #17623: [SPARK-20292][SQL][WIP] Clean up string represent...

2017-04-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17623#discussion_r111505420 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -149,7 +149,7 @@ case class Cast(child: Expression, dataType

[GitHub] spark pull request #17623: [SPARK-20292][SQL][WIP] Clean up string represent...

2017-04-12 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/17623 [SPARK-20292][SQL][WIP] Clean up string representation of TreeNode ## What changes were proposed in this pull request? Currently we have a lot of string representations for `QueryPlan`/`Exp