Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111535250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,22 +106,45 @@ case class ColumnStat(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111535093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -184,6 +196,26 @@ object ColumnStat extends
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111533868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/Range.scala
---
@@ -31,13 +27,13 @@ trait Range {
}
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111533746
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -184,6 +196,26 @@ object ColumnStat extends
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111533192
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,22 +106,45 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111527989
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/Range.scala
---
@@ -31,13 +27,13 @@ trait Range {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111527927
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -184,6 +196,26 @@ object ColumnStat extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111527880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -184,6 +196,26 @@ object ColumnStat extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111527840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,22 +106,45 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111527760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,22 +106,45 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111527735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,22 +106,45 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111527728
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,22 +106,45 @@ case class ColumnStat(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111521253
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,20 +106,38 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111521145
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,20 +106,38 @@ case class ColumnStat(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111521062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -352,14 +352,14 @@ object CatalogTable {
case class
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111517421
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,20 +106,38 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111402472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -352,14 +352,14 @@ object CatalogTable {
case
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111401893
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,20 +106,38 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111401570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,20 +106,38 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111401047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,20 +106,38 @@ case class ColumnStat(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111400807
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -104,20 +106,38 @@ case class ColumnStat(
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/17630
[SPARK-20318][SQL] Use Catalyst type for min/max in ColumnStat for ease of
estimation
## What changes were proposed in this pull request?
Currently when estimating predicates like col >
23 matches
Mail list logo
