[GitHub] spark pull request #17635: [SPARK-20335] [SQL] Children expressions of Hive ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17635#discussion_r111540615 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala --- @@ -84,6 +85,21 @@ class HiveUDAFSuite extends QueryTest with

[GitHub] spark pull request #17635: [SPARK-20335] [SQL] Children expressions of Hive ...

2017-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17635: [SPARK-20335] [SQL] Children expressions of Hive ...

2017-04-13 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/17635 [SPARK-20335] [SQL] Children expressions of Hive UDF impacts the determinism of Hive UDF ### What changes were proposed in this pull request? ```JAVA /** * Certain optimizations

[GitHub] spark pull request #17635: [SPARK-20335] [SQL] Children expressions of Hive ...

2017-04-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17635#discussion_r111531461 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala --- @@ -509,6 +509,19 @@ abstract class AggregationQue

[GitHub] spark pull request #17635: [SPARK-20335] [SQL] Children expressions of Hive ...

2017-04-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17635#discussion_r111531466 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala --- @@ -84,6 +85,21 @@ class HiveUDAFSuite extends QueryTest w