[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119762455 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -527,47 +527,117 @@ class PlanParserSuite extends

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119755764 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -527,47 +527,117 @@ class PlanParserSuite extends Pla

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119561805 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -407,7 +407,7 @@ class AstBuilder(conf: SQLConf) exten

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119271262 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -533,13 +533,16 @@ class AstBuilder(conf: SQLConf) extends

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119268299 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119267579 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -407,7 +407,7 @@ class AstBuilder(conf: SQLConf) exten

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119267472 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266987 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -525,47 +525,117 @@ class PlanParserSuite extends

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266645 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DSLHintSuite.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266598 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DSLHintSuite.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266605 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DSLHintSuite.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119169530 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -371,7 +371,7 @@ querySpecification (RECORDREAD

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119168868 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -371,7 +371,7 @@ querySpecification (RECORDREAD

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119143953 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -371,7 +371,7 @@ querySpecification (RECORDREADE

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119087361 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119087296 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -381,12 +381,12 @@ querySpecification ;

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119087261 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -371,7 +371,7 @@ querySpecification (RECORDREADE

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119085351 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal.

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118939619 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal.

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118832568 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118832533 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -518,47 +518,97 @@ class PlanParserSuite extends

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118832527 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118832466 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala --- @@ -91,7 +92,12 @@ object ResolveHints {

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118832456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118832415 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -381,12 +381,12 @@ querySpecification ;

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118832143 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -371,7 +371,7 @@ querySpecification (RECORDREAD

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118701338 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal.

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118661387 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal.

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118660663 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -533,13 +533,16 @@ class AstBuilder(conf: SQLConf) ext

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118473083 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -533,13 +533,16 @@ class AstBuilder(conf: SQLConf) extends

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118467770 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal.

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118467587 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -533,13 +533,16 @@ class AstBuilder(conf: SQLConf) ext

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r118467522 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -533,13 +533,16 @@ class AstBuilder(conf: SQLConf) ext

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

GitHub user bogdanrdc opened a pull request: https://github.com/apache/spark/pull/18086 [SPARK-20854][SQL] Extend hint syntax to support expressions ## What changes were proposed in this pull request? SQL hint syntax: * support expressions such as strings, numbers, etc.