Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18092
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r123040340
--- Diff: docs/configuration.md ---
@@ -639,6 +639,20 @@ Apart from these, the following properties are also
available, and may be useful
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r123040230
--- Diff: docs/configuration.md ---
@@ -639,6 +639,20 @@ Apart from these, the following properties are also
available, and may be useful
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122918448
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -303,6 +303,16 @@ package object config {
.bytesConf(ByteUn
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122918471
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -303,6 +303,16 @@ package object config {
.bytesConf(ByteUn
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122918254
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -132,7 +135,7 @@ public void registerWi
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122661511
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -49,6 +49,7 @@
private final Transp
Github user liyichao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122621671
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1286,61 @@ class BlockManagerSuite extends SparkFunSuite wit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122620995
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1286,61 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user liyichao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122620600
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1286,59 @@ class BlockManagerSuite extends SparkFunSuite wit
Github user liyichao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122620196
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1286,59 @@ class BlockManagerSuite extends SparkFunSuite wit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122617592
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1286,59 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122617448
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1286,59 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r122238555
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/mesos/MesosExternalShuffleClient.java
---
@@ -61,7 +61,7 @@ public Meso
Github user liyichao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121281612
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1285,57 @@ class BlockManagerSuite extends SparkFunSuite wit
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121269224
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -60,10 +61,19 @@
public External
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121269201
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1285,57 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121269157
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1285,57 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121269120
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1285,57 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121269114
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1285,57 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121269084
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1285,57 @@ class BlockManagerSuite extends SparkFunSuite wi
Github user liyichao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r118671187
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -170,11 +170,17 @@ private[spark] class BlockManager(
// service, o
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r118547246
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -170,11 +170,17 @@ private[spark] class BlockManager(
// service,
23 matches
Mail list logo