[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

2017-06-13 Thread actuaryzhang
Github user actuaryzhang closed the pull request at: https://github.com/apache/spark/pull/18116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

2017-05-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18116#discussion_r119211021 --- Diff: R/pkg/R/functions.R --- @@ -4015,3 +4015,31 @@ setMethod("input_file_name", signature("missing"), jc <-

[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

2017-05-25 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18116#discussion_r118634921 --- Diff: R/pkg/R/functions.R --- @@ -4015,3 +4015,29 @@ setMethod("input_file_name", signature("missing"), jc <-

[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

2017-05-25 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18116#discussion_r118634873 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1404,6 +1404,8 @@ test_that("column functions", { c20 <- to_timestamp(c) +

[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

2017-05-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18116#discussion_r118634196 --- Diff: R/pkg/R/functions.R --- @@ -4015,3 +4015,29 @@ setMethod("input_file_name", signature("missing"), jc <-

[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

2017-05-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18116#discussion_r118633949 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1404,6 +1404,8 @@ test_that("column functions", { c20 <- to_timestamp(c) +

[GitHub] spark pull request #18116: [SPARK-20892][SparkR] Add SQL trunc function to S...

2017-05-25 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18116#discussion_r118612551 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1404,6 +1404,8 @@ test_that("column functions", { c20 <- to_timestamp(c) +