Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r121177648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1205,8 +1204,8 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r120961406
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -61,7 +61,7 @@ class UDFRegistration private[sql] (functionRegistry:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r120960771
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -72,39 +95,53 @@ trait FunctionRegistry {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119959672
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -61,7 +61,7 @@ class UDFRegistration private[sql] (functionRegistry:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119959388
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -72,39 +89,53 @@ trait FunctionRegistry {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119959289
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -72,39 +95,53 @@ trait FunctionRegistry {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119167774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1152,27 +1151,27 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119159618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1152,27 +1151,27 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119014081
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -17,51 +17,74 @@
package org.apach
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119013261
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1205,8 +1204,8 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119013093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1116,8 +1115,8 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119012967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -72,39 +89,53 @@ trait FunctionRegistry {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18142#discussion_r119012802
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -72,39 +89,53 @@ trait FunctionRegistry {
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/18142
[SPARK-20918] [SQL] Use FunctionIdentifier as function identifiers in
FunctionRegistry
### What changes were proposed in this pull request?
Currently, the unquoted string of a function ident
15 matches
Mail list logo
