[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18189#discussion_r120296682 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -51,19 +51,17 @@ case class ResolvedHint(child: Logi

[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18189#discussion_r119979514 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala --- @@ -89,7 +89,7 @@ object ResolveHints { case

[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18189#discussion_r119979502 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala --- @@ -89,7 +89,7 @@ object ResolveHints { ca

[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18189#discussion_r119979389 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala --- @@ -51,19 +51,16 @@ case class ResolvedHint(child: Logical

[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18189#discussion_r119979349 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala --- @@ -89,7 +89,7 @@ object ResolveHints { case

[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18189#discussion_r119977859 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala --- @@ -89,7 +89,7 @@ object ResolveHints { c

[GitHub] spark pull request #18189: [SPARK-20972][SQL] rename HintInfo.isBroadcastabl...

2017-06-02 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/18189 [SPARK-20972][SQL] rename HintInfo.isBroadcastable to forceBroadcast ## What changes were proposed in this pull request? `HintInfo.isBroadcastable` is actually not an accurate name, it's