[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126373703 --- Diff: R/pkg/R/schema.R --- @@ -76,7 +76,7 @@ structType.structField <- function(x, ...) { #' @rdname structType #' @method structType chara

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126342705 --- Diff: R/pkg/R/schema.R --- @@ -23,7 +23,8 @@ #' Create a structType object that contains the metadata for a SparkDataFrame. Intended for #

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126342898 --- Diff: R/pkg/R/schema.R --- @@ -68,18 +73,10 @@ structType.structField <- function(x, ...) { structType(stObj) } -#' Create \cod

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126343428 --- Diff: R/pkg/R/schema.R --- @@ -76,7 +76,7 @@ structType.structField <- function(x, ...) { #' @rdname structType #' @method structType chara

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-09 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126299217 --- Diff: R/pkg/R/functions.R --- @@ -2163,10 +2164,15 @@ setMethod("date_format", signature(y = "Column", x = "character"), #' df2 <- sql("SELECT

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-09 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126299087 --- Diff: R/pkg/R/functions.R --- @@ -2163,10 +2164,15 @@ setMethod("date_format", signature(y = "Column", x = "character"), #' df2 <- sql("SELECT

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126298114 --- Diff: R/pkg/R/functions.R --- @@ -2163,10 +2164,15 @@ setMethod("date_format", signature(y = "Column", x = "character"), #' df2 <- sql("SELECT

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126296188 --- Diff: R/pkg/R/functions.R --- @@ -2163,10 +2164,15 @@ setMethod("date_format", signature(y = "Column", x = "character"), #' df2 <- sql("SELECT

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126295982 --- Diff: R/pkg/R/functions.R --- @@ -2163,10 +2164,15 @@ setMethod("date_format", signature(y = "Column", x = "character"), #' df2 <- sql("SELECT

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126290322 --- Diff: R/pkg/R/schema.R --- @@ -68,6 +68,28 @@ structType.structField <- function(x, ...) { structType(stObj) } +#' Create \code

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126284016 --- Diff: python/pyspark/sql/functions.py --- @@ -1856,7 +1860,9 @@ def from_json(col, schema, options={}): """ sc = SparkContext

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126283837 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3078,9 +3078,8 @@ object functions { * string. * *

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126283829 --- Diff: python/pyspark/sql/functions.py --- @@ -1839,15 +1839,19 @@ def from_json(col, schema, options={}): string. :param col:

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125523736 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3078,9 +3078,8 @@ object functions { * string. * *

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126276943 --- Diff: R/pkg/R/group.R --- @@ -237,6 +237,10 @@ gapplyInternal <- function(x, func, schema) { connection = NULL) br

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126277047 --- Diff: python/pyspark/sql/functions.py --- @@ -1839,15 +1839,19 @@ def from_json(col, schema, options={}): string. :param col:

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126276470 --- Diff: R/pkg/NAMESPACE --- @@ -430,6 +430,7 @@ export("structField", "print.structField", "structType", "structTyp

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126277167 --- Diff: python/pyspark/sql/functions.py --- @@ -1856,7 +1860,9 @@ def from_json(col, schema, options={}): """ sc = SparkContext

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r126276767 --- Diff: R/pkg/R/schema.R --- @@ -68,6 +68,29 @@ structType.structField <- function(x, ...) { structType(stObj) } +#' Create \code

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125190454 --- Diff: python/pyspark/sql/functions.py --- @@ -1839,15 +1839,19 @@ def from_json(col, schema, options={}): string. :param col:

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread liguohua-bigdata
Github user liguohua-bigdata commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125174835 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1504,14 +1513,15 @@ test_that("column functions", { # check if array type in string i

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125169040 --- Diff: python/pyspark/sql/functions.py --- @@ -1839,15 +1839,19 @@ def from_json(col, schema, options={}): string. :param col:

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125168993 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3078,9 +3078,8 @@ object functions { * string. * *

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125168486 --- Diff: python/pyspark/sql/functions.py --- @@ -1839,7 +1839,8 @@ def from_json(col, schema, options={}): string. :param col: s

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125168275 --- Diff: python/pyspark/sql/functions.py --- @@ -1839,15 +1839,19 @@ def from_json(col, schema, options={}): string. :param col:

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125167705 --- Diff: python/pyspark/sql/functions.py --- @@ -1839,7 +1839,8 @@ def from_json(col, schema, options={}): string. :param col: s

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125158975 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1480,13 +1487,15 @@ test_that("column functions", { j <- collect(select(df, alias(to_json(

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125158960 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1504,14 +1513,15 @@ test_that("column functions", { # check if array type in string is cor

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125158943 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -2885,30 +2895,33 @@ test_that("dapply() and dapplyCollect() on a DataFrame", { expect_ide

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18498#discussion_r125158920 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3020,29 +3033,32 @@ test_that("gapply() and gapplyCollect() on a DataFrame", { # Co

[GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...

2017-07-01 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/18498 [SPARK-21266][R][PYTHON] Support schema a DDL-formatted string in dapply/gapply/from_json ## What changes were proposed in this pull request? This PR supports schema in a DDL formatted