Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18554#discussion_r126868713
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -317,7 +318,12 @@ final class OneVsRest @Since("1.4.0") (
Github user facaiy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18554#discussion_r126863072
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -317,7 +318,12 @@ final class OneVsRest @Since("1.4.0") (
v
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18554#discussion_r126710934
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -317,7 +318,12 @@ final class OneVsRest @Since("1.4.0") (
GitHub user facaiy opened a pull request:
https://github.com/apache/spark/pull/18554
[SPARK-21306][ML] OneVsRest should cache weightCol if necessary
## What changes were proposed in this pull request?
cache weightCol if classifier inherits HasWeightCol trait.
## How
