Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18634
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r128228043
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -359,37 +359,41 @@ class SQLWindowFunctionSuite
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r128227194
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -356,6 +356,46 @@ class SQLWindowFunctionSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r128220833
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -356,6 +356,46 @@ class SQLWindowFunctionSuite
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r128215724
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -359,37 +359,41 @@ class SQLWindowFunctionSuite
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r128142152
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -356,6 +356,42 @@ class SQLWindowFunctionSuite
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r127882623
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -356,6 +356,42 @@ class SQLWindowFunctionSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r127882430
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -356,6 +356,42 @@ class SQLWindowFunctionSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r127882358
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -356,6 +356,42 @@ class SQLWindowFunctionSuite
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18634#discussion_r127696829
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala
---
@@ -212,6 +203,21 @@ private[window] final class
GitHub user jinxing64 opened a pull request:
https://github.com/apache/spark/pull/18634
[SPARK-21414] Refine SlidingWindowFunctionFrame to avoid OOM.
## What changes were proposed in this pull request?
In `SlidingWindowFunctionFrame`, it is now adding all rows to the buffer
11 matches
Mail list logo
