Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18655
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129735129
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -77,95 +59,55 @@ private[sql] object ArrowConverter
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129488362
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
---
@@ -857,6 +857,449 @@ class ArrowConvertersSuite exten
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129487716
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala
---
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Softwa
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129486273
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowWriterSuite.scala
---
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache S
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129486171
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala
---
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Softwa
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129484715
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -77,95 +59,55 @@ private[sql] object ArrowConverter
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129482346
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
---
@@ -857,6 +857,449 @@ class ArrowConvertersSuite
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129481638
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala
---
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache S
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129480466
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowWriterSuite.scala
---
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apach
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129480291
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala
---
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Sof
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129480076
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -77,95 +59,55 @@ private[sql] object ArrowConverters
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129477483
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -77,95 +59,55 @@ private[sql] object ArrowConverters {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r129477058
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -77,95 +59,55 @@ private[sql] object ArrowConverters
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128598428
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
---
@@ -391,6 +392,85 @@ class ArrowConvertersSuite e
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128313325
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
---
@@ -391,6 +392,85 @@ class ArrowConvertersSuite e
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128312860
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -55,145 +51,55 @@ private[sql] class ArrowPayload p
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128146875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
---
@@ -391,6 +392,85 @@ class ArrowConvertersSuite extend
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128146851
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -55,145 +51,55 @@ private[sql] class ArrowPayload privat
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128146856
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/vectorized/ArrowWriter.scala
---
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the Apache S
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128146843
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -55,145 +51,55 @@ private[sql] class ArrowPayload privat
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128064603
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
---
@@ -391,6 +392,85 @@ class ArrowConvertersSuite e
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128064385
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/vectorized/ArrowWriter.scala
---
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the Apa
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128062715
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -55,145 +51,55 @@ private[sql] class ArrowPayload p
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128061312
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -55,145 +51,55 @@ private[sql] class ArrowPayload p
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r128061219
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala
---
@@ -55,145 +51,55 @@ private[sql] class ArrowPayload p
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r127734562
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ArrowColumnVector.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apach
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18655#discussion_r127704333
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ArrowColumnVector.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apach
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/18655
[SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and add DecimalType,
ArrayType and StructType support.
## What changes were proposed in this pull request?
This is a refactoring of `Arr
29 matches
Mail list logo
