GitHub user ajaysaini725 opened a pull request:
https://github.com/apache/spark/pull/18742
Python persistence helper functions
## What changes were proposed in this pull request?
Added DefaultParamsWriteable, DefaultParamsReadable, DefaultParamsWriter,
and DefaultParamsReader to Python to support Python-only persistence of
Json-serializable parameters.
## How was this patch tested?
Instantiated an estimator with Json-serializable parameters (ex.
LogisticRegression), saved it using the added helper functions, and loaded it
back, and compared it to the original instance to make sure it is the same.
This test was done in both the Python REPL and the unit tests.
Note to reviewers: there are a few excess comments that I left in the code
for clarity but will remove before the code is merged to master.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajaysaini725/spark
PythonPersistenceHelperFunctions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18742
----
commit 71771e55517f7b00960b54ab7ac0248643990cbc
Author: Ajay Saini <ajays...@gmail.com>
Date: 2017-07-20T02:16:50Z
Function outline
commit 7974496912aca3512bac69039fd27b2ca0c35626
Author: Ajay Saini <ajays...@gmail.com>
Date: 2017-07-26T22:44:31Z
Working default read and write helper functions. Code does not pass style
tests and still has comments.
commit 9cb114bfce8a86e50b57384435f850c75d8507b7
Author: Ajay Saini <ajays...@gmail.com>
Date: 2017-07-26T22:53:24Z
Removed excess comments and fixed style issues.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
