[GitHub] spark pull request #18992: [SPARK-19762][ML][FOLLOWUP]Add necessary comments...

2017-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18992 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18992: [SPARK-19762][ML][FOLLOWUP]Add necessary comments...

2017-08-20 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/18992#discussion_r134109929 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularization.scala --- @@ -57,6 +61,11 @@ private[ml] class L2Regulariza

[GitHub] spark pull request #18992: [SPARK-19762][ML][FOLLOWUP]Add necessary comments...

2017-08-18 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/18992 [SPARK-19762][ML][FOLLOWUP]Add necessary comments to L2Regularization. ## What changes were proposed in this pull request? MLlib LiR/LoR/SR always standardize the data during training to impr