GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/18993
[SPARK-21743][SQL][follow-up] top-most limit should not cause memory leak
## What changes were proposed in this pull request?
This is a follow-up of https://github.com/apache/spark/pull/1
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133941559
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -54,14 +54,6 @@ trait BaseLimitExec extends UnaryExecNode with
Codege
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133941776
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -63,29 +63,24 @@ abstract class SparkStrategies extends
Que
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133941801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -63,29 +63,24 @@ abstract class SparkStrategies extends
Que
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133941933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1180,6 +1180,9 @@ object ConvertToLocalRelation ext
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133943823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1180,6 +1180,9 @@ object ConvertToLocalRelation ex
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133971618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1180,6 +1180,9 @@ object ConvertToLocalRelation ext
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133972522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1180,6 +1180,9 @@ object ConvertToLocalRelation ex
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18993
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
