[GitHub] spark pull request #19117: [SPARK-21904] [SQL] Rename tempTables to tempView...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19117 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19117: [SPARK-21904] [SQL] Rename tempTables to tempView...

2017-09-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19117#discussion_r137142990 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -812,7 +812,7 @@ abstract class DDLSuite extends QueryTest wi

[GitHub] spark pull request #19117: [SPARK-21904] [SQL] Rename tempTables to tempView...

2017-09-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19117#discussion_r137142830 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -812,7 +812,7 @@ abstract class DDLSuite extends QueryTest wi

[GitHub] spark pull request #19117: [SPARK-21904] [SQL] Rename tempTables to tempView...

2017-09-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19117#discussion_r137142923 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -860,7 +860,7 @@ abstract class DDLSuite extends QueryTest wi

[GitHub] spark pull request #19117: [SPARK-21904] [SQL] Rename tempTables to tempView...

2017-09-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19117#discussion_r137142277 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -90,13 +87,13 @@ class SessionCatalog( ne

[GitHub] spark pull request #19117: [SPARK-21904] [SQL] Rename tempTables to tempView...

2017-09-03 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19117 [SPARK-21904] [SQL] Rename tempTables to tempViews in SessionCatalog ### What changes were proposed in this pull request? `tempTables` is not right. To be consistent, we need to rename the in