Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19122
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r146940974
--- Diff: python/pyspark/ml/tests.py ---
@@ -836,6 +836,27 @@ def test_save_load_simple_estimator(self):
loadedModel = CrossValidatorModel.loa
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r146941252
--- Diff: python/pyspark/ml/tests.py ---
@@ -836,6 +836,27 @@ def test_save_load_simple_estimator(self):
loadedModel = CrossValidatorModel.loa
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140600118
--- Diff: python/pyspark/ml/tests.py ---
@@ -836,6 +836,27 @@ def test_save_load_simple_estimator(self):
loadedModel = CrossValidatorModel.l
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140402700
--- Diff: python/pyspark/ml/tests.py ---
@@ -836,6 +836,27 @@ def test_save_load_simple_estimator(self):
loadedModel = CrossValidatorModel.
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140375759
--- Diff: python/pyspark/ml/tests.py ---
@@ -836,6 +836,27 @@ def test_save_load_simple_estimator(self):
loadedModel = CrossValidatorModel.loa
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140375921
--- Diff: python/pyspark/ml/tuning.py ---
@@ -14,15 +14,16 @@
# See the License for the specific language governing permissions and
# limitations
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140375849
--- Diff: python/pyspark/ml/tests.py ---
@@ -986,6 +1007,25 @@ def test_save_load_simple_estimator(self):
loadedModel = TrainValidationSplitMo
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140377904
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,30 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = data
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140373348
--- Diff: python/pyspark/ml/tuning.py ---
@@ -14,15 +14,16 @@
# See the License for the specific language governing permissions and
# limitatio
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140376994
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,30 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = data
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r140375935
--- Diff: python/pyspark/ml/tests.py ---
@@ -836,6 +836,27 @@ def test_save_load_simple_estimator(self):
loadedModel = CrossValidatorModel.l
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138518283
--- Diff: python/pyspark/ml/tuning.py ---
@@ -193,7 +194,8 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
>>> lr
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138518235
--- Diff: python/pyspark/ml/tuning.py ---
@@ -208,23 +210,23 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138249937
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -152,6 +152,8 @@ def get$Name(self):
("varianceCol", "column name for t
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138151063
--- Diff: python/pyspark/ml/tuning.py ---
@@ -193,7 +194,8 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
>>> lr
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138144992
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -152,6 +152,8 @@ def get$Name(self):
("varianceCol", "column name for th
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138144361
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,27 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = data
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138142834
--- Diff: python/pyspark/ml/tuning.py ---
@@ -208,23 +210,23 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r137264588
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,23 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dat
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r137175343
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,24 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dat
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r137162378
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,24 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dataset.s
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r137162089
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,23 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dataset.s
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r136934638
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,24 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dat
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r136933807
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,23 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dat
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r136924008
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,24 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dataset.s
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r136915493
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,23 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dataset.s
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r136850665
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,23 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = dat
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/19122
[SPARK-21911][ML][PySpark] Parallel Model Evaluation for ML Tuning in
PySpark
## What changes were proposed in this pull request?
Add parallelism support for ML tuning in pyspark.
29 matches
Mail list logo
