[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-17 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r145225179 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2208,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-17 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r145183505 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2208,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r145027904 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala --- @@ -137,11 +137,15 @@ object ExtractPythonUDFs extends

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r145012436 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala --- @@ -137,11 +137,15 @@ object ExtractPythonUDFs

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144936208 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2205,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144933717 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2208,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144929491 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2205,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144927194 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2205,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144926703 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2205,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144926010 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2205,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144924728 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,40 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144924765 --- Diff: python/pyspark/sql/functions.py --- @@ -2038,13 +2038,19 @@ def _wrap_function(sc, func, returnType):

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144917550 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2205,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144917109 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2205,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144915012 --- Diff: python/pyspark/sql/functions.py --- @@ -2038,13 +2038,19 @@ def _wrap_function(sc, func, returnType):

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144912405 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,40 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144859965 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,35 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144859680 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,35 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144859561 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,35 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144857957 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,35 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144852099 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,35 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144848936 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,35 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144839348 --- Diff: python/pyspark/sql/functions.py --- @@ -2121,33 +2127,35 @@ def wrapper(*args): wrapper.func = self.func

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144780828 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2195,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144780130 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2195,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144768754 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2195,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144768646 --- Diff: python/pyspark/sql/functions.py --- @@ -2192,67 +2195,82 @@ def pandas_udf(f=None, returnType=StringType()): :param f: user-defined

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144768652 --- Diff: python/pyspark/sql/functions.py --- @@ -2044,7 +2044,7 @@ class UserDefinedFunction(object): .. versionadded:: 1.3 """

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19505#discussion_r144768380 --- Diff: python/pyspark/sql/functions.py --- @@ -2044,7 +2044,7 @@ class UserDefinedFunction(object): .. versionadded:: 1.3 """

[GitHub] spark pull request #19505: [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby()....

2017-10-16 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/19505 [SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby().apply() with pandas udf ## What changes were proposed in this pull request? This is a follow-up of #18732. This pr introduces