[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19519 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-24 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r146737263 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApplication.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-24 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r146734568 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApplication.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-24 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r146734075 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApplication.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-23 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r146332249 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApplication.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-22 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r146154530 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApplication.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r145495282 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -235,11 +235,11 @@ object SparkSubmit extends CommandLineUtils with

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r145492860 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -235,11 +235,11 @@ object SparkSubmit extends CommandLineUtils with Logging {

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19519#discussion_r145491446 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -235,11 +235,11 @@ object SparkSubmit extends CommandLineUtils with

[GitHub] spark pull request #19519: [SPARK-21840][core] Add trait that allows conf to...

2017-10-17 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/19519 [SPARK-21840][core] Add trait that allows conf to be directly set in application. Currently SparkSubmit uses system properties to propagate configuration to applications. This makes it hard to