Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19548
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user taroplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146160084
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -815,6 +815,12 @@ class JDBCSuite extends SparkFunSuite
Some(
Github user taroplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146160039
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -108,6 +112,10 @@ class OracleInt
Github user taroplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146160051
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -307,4 +315,32 @@ class OracleInt
Github user taroplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146160013
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -50,9 +52,11 @@ import org.apache
Github user taroplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146159980
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -28,25 +28,28 @@ private case object OracleDialect extends JdbcDiale
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146147276
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -108,6 +112,10 @@ class OracleInteg
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146147286
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -50,9 +52,11 @@ import org.apache.s
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146147293
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -815,6 +815,12 @@ class JDBCSuite extends SparkFunSuite
Some(De
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146147267
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -307,4 +315,32 @@ class OracleInteg
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19548#discussion_r146120958
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -28,25 +28,28 @@ private case object OracleDialect extends JdbcDia
GitHub user taroplus opened a pull request:
https://github.com/apache/spark/pull/19548
[SPARK-22303][SQL] Handle Oracle specific jdbc types in OracleDialect
TIMESTAMP (-101), BINARY_DOUBLE (101) and BINARY_FLOAT (100) are handled in
OracleDialect
## What changes were propos
12 matches
Mail list logo
