Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19730
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r15498
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -827,4 +827,49 @@ class CastSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151725673
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1039,13 +1039,19 @@ case class Cast(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151723565
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -827,4 +827,34 @@ class CastSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151723430
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -827,4 +827,34 @@ class CastSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151509423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1039,13 +1039,19 @@ case class Cast(child: Expression,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151477316
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1039,13 +1039,19 @@ case class Cast(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r151476367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1039,13 +1039,19 @@ case class Cast(child:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r150609735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1039,13 +1039,19 @@ case class Cast(child: Expression,
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r150584342
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1039,13 +1039,19 @@ case class Cast(child: Expression,
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r150419888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1015,7 +1015,9 @@ case class Cast(child: Expression,
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r150419908
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -1015,7 +1015,9 @@ case class Cast(child: Expression,
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/19730
[SPARK-22500][SQL] Fix 64KB JVM bytecode limit problem with cast
## What changes were proposed in this pull request?
This PR changes `cast` code generation to place generated code for
13 matches
Mail list logo