[GitHub] spark pull request #19790: [SPARK-22569] [SQL] Clean usage of addMutableStat...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19790 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19790: [SPARK-22569] [SQL] Clean usage of addMutableStat...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19790#discussion_r152200760 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -205,27 +209,32 @@ case class ConcatWs(ch

[GitHub] spark pull request #19790: [SPARK-22569] [SQL] Clean usage of addMutableStat...

2017-11-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19790#discussion_r152195602 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -205,27 +209,32 @@ case class ConcatWs(chi

[GitHub] spark pull request #19790: [SPARK-22569] [SQL] Clean usage of addMutableStat...

2017-11-20 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19790 [SPARK-22569] [SQL] Clean usage of addMutableState and splitExpressions ## What changes were proposed in this pull request? This PR is to clean the usage of addMutableState and splitExpressio