[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

2017-12-06 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/19883 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

2017-12-06 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19883#discussion_r155226705 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -444,11 +444,11 @@ case class

[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

2017-12-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19883#discussion_r155222959 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -444,11 +444,11 @@ case class

[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

2017-12-06 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19883#discussion_r155221911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -444,11 +444,11 @@ case class

[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

2017-12-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19883#discussion_r155221232 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -444,11 +444,11 @@ case class

[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

2017-12-04 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/19883 [SPARK-22684][SQL] datetime functions should not generate useless mutable states ## What changes were proposed in this pull request? Some datetime functions are defining mutable states