[GitHub] spark pull request #20000: [SPARK-22815] [SQL] Keep PromotePrecision in Opti...

2017-12-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20000: [SPARK-22815] [SQL] Keep PromotePrecision in Opti...

2017-12-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/2#discussion_r157513373 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala --- @@ -20,7 +20,10 @@ package

[GitHub] spark pull request #20000: [SPARK-22815] [SQL] Keep PromotePrecision in Opti...

2017-12-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/2#discussion_r157430602 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala --- @@ -20,7 +20,10 @@ package

[GitHub] spark pull request #20000: [SPARK-22815] [SQL] Keep PromotePrecision in Opti...

2017-12-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/2#discussion_r157380176 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala --- @@ -20,7 +20,10 @@ package

[GitHub] spark pull request #20000: [SPARK-22815] [SQL] Keep PromotePrecision in Opti...

2017-12-17 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/2#discussion_r157376590 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala --- @@ -20,7 +20,10 @@ package

[GitHub] spark pull request #20000: [SPARK-22815] [SQL] Keep PromotePrecision in Opti...

2017-12-16 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/2 [SPARK-22815] [SQL] Keep PromotePrecision in Optimized Plans ## What changes were proposed in this pull request? We could get incorrect results by running DecimalPrecision twice.