Github user bdrillard closed the pull request at:
https://github.com/apache/spark/pull/20085
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r161607649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1237,47 +1342,91 @@ case class DecodeUsingS
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r160349007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1237,47 +1342,91 @@ case class DecodeUsingS
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r160347559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -182,6 +182,111 @@ case class StaticInvoke(
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r159520020
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -436,4 +437,16 @@ class CodeGenerationSu
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r159519915
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/GenericBean.java
---
@@ -0,0 +1,56 @@
+package org.apache.spark.sql.ca
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r159519672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1237,47 +1342,91 @@ case class DecodeUsingS
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r158761511
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -390,8 +391,8 @@ class CodeGenerationSui
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r158761155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -106,27 +106,27 @@ trait InvokeLike extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r158760302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -182,6 +182,114 @@ case class StaticInvoke(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r158760292
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -182,6 +182,114 @@ case class StaticInvoke(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r158759848
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -390,8 +391,8 @@ class CodeGenerationSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20085#discussion_r158759244
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -106,27 +106,27 @@ trait InvokeLike extends Exp
GitHub user bdrillard opened a pull request:
https://github.com/apache/spark/pull/20085
[SPARK-22739][Catalyst][WIP] Additional Expression Support for Objects
## What changes were proposed in this pull request?
This PR is a work-in-progress adding additional `Expression` sup
14 matches
Mail list logo
