Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20169#discussion_r163434724
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -82,8 +83,9 @@ import org.apache.spark.util.{CircularBuffer,
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20169#discussion_r163434545
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -82,8 +83,9 @@ import org.apache.spark.util.{CircularBuffer,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20169#discussion_r163431536
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -82,8 +83,9 @@ import org.apache.spark.util.{CircularBuff
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20169#discussion_r163431452
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -82,8 +83,9 @@ import org.apache.spark.util.{CircularBuff
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20169#discussion_r163429951
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -82,8 +83,9 @@ import org.apache.spark.util.{CircularBuffer,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20169#discussion_r163429758
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -82,8 +83,9 @@ import org.apache.spark.util.{CircularBuff
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20169#discussion_r163429626
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -82,8 +83,9 @@ import org.apache.spark.util.{CircularBuff
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20169
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/20169
[SPARK-17088][hive] Fix 'sharesHadoopClasses' option when creating client.
Because the call to the constructor of HiveClientImpl crosses class loader
boundaries, different versions of the same cl