Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20171
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161723055
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +261,55 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161719551
--- Diff: python/pyspark/sql/context.py ---
@@ -174,18 +174,23 @@ def range(self, start, end=None, step=1,
numPartitions=None):
@ignore_u
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161710081
--- Diff: python/pyspark/sql/context.py ---
@@ -174,18 +174,23 @@ def range(self, start, end=None, step=1,
numPartitions=None):
@ignore_unicod
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161711905
--- Diff: python/pyspark/sql/tests.py ---
@@ -3975,33 +4003,50 @@ def
test_vectorized_udf_timestamps_respect_session_timezone(self):
finally:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161709870
--- Diff: python/pyspark/sql/catalog.py ---
@@ -226,18 +226,23 @@ def dropGlobalTempView(self, viewName):
@ignore_unicode_prefix
@sinc
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161711980
--- Diff: python/pyspark/sql/tests.py ---
@@ -4037,6 +4082,15 @@ def test_simple(self):
expected =
df.toPandas().groupby('id').apply(foo_udf.fun
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161659245
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sql("S
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161657719
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161654514
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sql("S
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161654136
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161651611
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sql("S
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161650064
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161649821
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlConte
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161649497
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161649243
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161649275
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161647635
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161647332
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161647061
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161643600
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sql("S
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161640273
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161639815
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlConte
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161638977
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161638411
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161637979
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161637065
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161635142
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161635087
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlConte
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161631616
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161605021
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161604763
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161603693
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161592401
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161579882
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161532662
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161532260
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161531698
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlConte
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161414603
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161414948
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161414648
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161415247
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161400802
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161400597
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,56 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161402514
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,56 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385548
--- Diff: python/pyspark/sql/tests.py ---
@@ -380,10 +380,16 @@ def test_udf2(self):
def test_udf3(self):
twoargs = self.spar
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385502
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,56 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385427
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,56 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385482
--- Diff: python/pyspark/sql/context.py ---
@@ -204,15 +206,31 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> sqlCont
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385554
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3622,21 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385550
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3622,21 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385602
--- Diff: python/pyspark/sql/tests.py ---
@@ -4037,6 +4075,21 @@ def test_simple(self):
expected =
df.toPandas().groupby('id').apply(foo_ud
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161385504
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,56 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
GitHub user gatorsmile reopened a pull request:
https://github.com/apache/spark/pull/20171
[SPARK-22978] [PySpark] Register Vectorized UDFs for SQL Statement [WIP]
## What changes were proposed in this pull request?
Register Vectorized UDFs for SQL Statement. For example,
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/20171
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160583088
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160441123
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160333599
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160319860
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160318854
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160318804
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160319379
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160318424
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160310548
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160229142
--- Diff: python/pyspark/sql/tests.py ---
@@ -3616,6 +3616,34 @@ def test_vectorized_udf_basic(self):
bool_f(col('bool')))
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160089864
--- Diff: python/pyspark/sql/catalog.py ---
@@ -265,12 +267,23 @@ def registerFunction(self, name, f,
returnType=StringType()):
[Row(random
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160086985
--- Diff: python/pyspark/sql/catalog.py ---
@@ -265,12 +267,23 @@ def registerFunction(self, name, f,
returnType=StringType()):
[Row(random_
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r160048270
--- Diff: python/pyspark/sql/catalog.py ---
@@ -265,12 +267,23 @@ def registerFunction(self, name, f,
returnType=StringType()):
[Row(random
68 matches
Mail list logo