[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160040256 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -666,4 +666,16 @@ class DataFrameAggregateSuite extends QueryTest

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160040214 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -245,11 +252,15 @@ case class HashAggregateExec(

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160040102 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -106,6 +106,8 @@ case class HashAggregateExec(

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160040260 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -666,4 +666,16 @@ class DataFrameAggregateSuite extends QueryTest

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user liufengdb commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160042482 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -245,11 +252,15 @@ case class HashAggregateExec

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160114031 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -102,10 +102,12 @@ case class HashAggregateExec(

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160126732 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -230,6 +236,7 @@ case class HashAggregateExec(

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user liufengdb commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160216751 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -102,10 +102,12 @@ case class HashAggregateExec

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user liufengdb commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160217718 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -230,6 +236,7 @@ case class HashAggregateExec(

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160301233 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -230,6 +236,7 @@ case class HashAggregateExec(

[GitHub] spark pull request #20174: [SPARK-22951][SQL] aggregate should not produce e...

Github user liufengdb commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160305419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -230,6 +236,7 @@ case class HashAggregateExec(