[GitHub] spark pull request #20180: [SPARK-22983] Don't push filters beneath aggregat...

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20180 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20180: [SPARK-22983] Don't push filters beneath aggregat...

2018-01-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20180#discussion_r160068407 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql --- @@ -60,3 +60,12 @@ SELECT a, COUNT(1) FROM testData WHERE false GROUP BY a;

[GitHub] spark pull request #20180: [SPARK-22983] Don't push filters beneath aggregat...

2018-01-07 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/20180 [SPARK-22983] Don't push filters beneath aggregates with empty grouping expressions ## What changes were proposed in this pull request? The following SQL query should return zero rows,