[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20214 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-12 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161358894 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1255,6 +1255,34 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161255253 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1255,6 +1255,34 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161254906 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,17 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-11 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161156501 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,18 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161153123 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,18 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-11 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161131086 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,18 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-11 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161130049 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,19 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161123911 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,19 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161123821 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,19 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r161123864 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,13 +237,19 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r160613267 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1255,6 +1255,34 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-10 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20214#discussion_r160613124 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1255,6 +1255,34 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #20214: [SPARK-23023][SQL] Cast field data to strings in ...

2018-01-09 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20214 [SPARK-23023][SQL] Cast field data to strings in showString ## What changes were proposed in this pull request? The current `Datset.showString` prints rows thru `RowEncoder` deserializers like;