Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20254
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20254#discussion_r161377477
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1364,7 +1364,9 @@ def subtract(self, other):
""" Return a new :class:`DataFrame`
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20254#discussion_r161377488
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2873,6 +2873,7 @@ setMethod("intersect",
#' @rdname except
#' @export
#' @note except since 1.4.0
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20254#discussion_r161365422
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1364,7 +1364,9 @@ def subtract(self, other):
""" Return a new :class:`DataFrame`
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20254#discussion_r161365371
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2873,6 +2873,7 @@ setMethod("intersect",
#' @rdname except
#' @export
#' @note except since 1.4.0
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20254#discussion_r161365416
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2873,6 +2873,7 @@ setMethod("intersect",
#' @rdname except
#' @export
#' @note except since 1.4.0
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20254#discussion_r161358664
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1364,7 +1364,9 @@ def subtract(self, other):
""" Return a new :class:`DataFrame`
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20254#discussion_r161358593
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2873,6 +2873,7 @@ setMethod("intersect",
#' @rdname except
#' @export
#' @note except since 1.4.0
GitHub user henryr opened a pull request:
https://github.com/apache/spark/pull/20254
[SPARK-23062][SQL] Improve EXCEPT documentation
## What changes were proposed in this pull request?
Make the default behavior of EXCEPT (i.e. EXCEPT DISTINCT) more
explicit in the
