[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20257 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r162043736 --- Diff: docs/ml-features.md --- @@ -783,11 +783,11 @@ Because this existing `OneHotEncoder` is a stateless transformer, it is not usab ##

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-17 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r162040939 --- Diff: docs/ml-features.md --- @@ -783,11 +783,11 @@ Because this existing `OneHotEncoder` is a stateless transformer, it is not usab ##

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-17 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r162038403 --- Diff: docs/ml-features.md --- @@ -783,11 +783,11 @@ Because this existing `OneHotEncoder` is a stateless transformer, it is not usab ##

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-17 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161989945 --- Diff: docs/ml-features.md --- @@ -777,17 +777,17 @@ for more details on the API. ## OneHotEncoder (Deprecated since 2.3.0) -Because

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-17 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161989107 --- Diff: docs/ml-features.md --- @@ -777,17 +777,17 @@ for more details on the API. ## OneHotEncoder (Deprecated since 2.3.0) -Because

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-17 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161988396 --- Diff: docs/ml-features.md --- @@ -777,17 +777,17 @@ for more details on the API. ## OneHotEncoder (Deprecated since 2.3.0) -Because

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161928937 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaOneHotEncoderEstimatorExample.java --- @@ -35,41 +34,37 @@ import

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161859425 --- Diff: docs/ml-features.md --- @@ -775,35 +775,43 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161857103 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaOneHotEncoderEstimatorExample.java --- @@ -35,41 +34,37 @@ import

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161854406 --- Diff: docs/ml-features.md --- @@ -775,35 +775,43 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161722235 --- Diff: docs/ml-features.md --- @@ -775,35 +775,43 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161740882 --- Diff: examples/src/main/python/ml/onehot_encoder_estimator_example.py --- @@ -18,32 +18,31 @@ from __future__ import print_function #

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161739866 --- Diff: docs/ml-features.md --- @@ -775,35 +775,43 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161741274 --- Diff: docs/ml-features.md --- @@ -775,35 +775,43 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161740612 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaOneHotEncoderEstimatorExample.java --- @@ -35,41 +34,37 @@ import

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161739788 --- Diff: docs/ml-features.md --- @@ -775,35 +775,43 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161722104 --- Diff: docs/ml-features.md --- @@ -775,35 +775,43 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-16 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161740927 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/OneHotEncoderEstimatorExample.scala --- @@ -19,38 +19,34 @@ package

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161645057 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161644962 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/OneHotEncoderEstimatorExample.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161644708 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161644705 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161472191 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161477464 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/OneHotEncoderEstimatorExample.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161475879 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161473460 --- Diff: docs/ml-features.md --- @@ -807,6 +809,36 @@ for more details on the API. +## OneHotEncoderEstimator + +[One-hot

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161472954 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-13 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/20257 [SPARK-23048][ML] Add OneHotEncoderEstimator document and examples ## What changes were proposed in this pull request? We have `OneHotEncoderEstimator` now and `OneHotEncoder` will be