Github user heary-cao closed the pull request at:
https://github.com/apache/spark/pull/20516
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167403542
--- Diff: project/SparkBuild.scala ---
@@ -792,7 +792,6 @@ object TestSettings {
"JAVA_HOME" ->
sys.env.get("JAVA_HOME").getOrElse(sys.props("java
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167175502
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167159549
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167158512
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167156814
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167137766
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -,7 +,7 @@ private[spark] object Utils extends Logging {
*/
d
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167134346
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167133408
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -,7 +,7 @@ private[spark] object Utils extends Logging {
*/
d
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167133433
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166849307
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferServi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166848789
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferService
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166814031
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferService
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767609
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferServiceSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767674
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferServiceSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767449
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferServiceSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166767860
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferServiceSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166766796
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,53 @@ class NettyBlockTransferServiceSui
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166507524
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,68 @@ class NettyBlockTransferService
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166494159
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,68 @@ class NettyBlockTransferService
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166348587
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,68 @@ class NettyBlockTransferServiceSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166350354
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,68 @@ class NettyBlockTransferServiceSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166350486
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,68 @@ class NettyBlockTransferServiceSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r166349531
--- Diff:
core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala
---
@@ -77,16 +79,68 @@ class NettyBlockTransferServiceSui
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/20516
[SPARK-23343][CORE][TEST] Increase the exception test for the bind port
## What changes were proposed in this pull request?
this PR add new test case,
1ãadd the boundary value test
25 matches
Mail list logo