[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20670 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171463022 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -22,21 +22,24 @@ import

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171462811 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -22,21 +22,24 @@ import

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171276798 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala --- @@ -192,4 +192,17 @@ class

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-28 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171201415 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -22,21 +22,30 @@ import

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171182870 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala --- @@ -192,4 +192,17 @@ class

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171182439 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala --- @@ -192,4 +192,17 @@ class

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171182102 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -22,21 +22,30 @@ import

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r171102033 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -23,20 +23,23 @@ import

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

2018-02-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20670#discussion_r170840898 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -27,16 +27,15 @@ trait