[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20694 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r173584456 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala --- @@ -780,6 +781,25 @@ class ParquetIOSuite

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r173584348 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -680,4 +682,31 @@ class JsonExpression

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r173584330 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -680,4 +682,31 @@ class JsonExpression

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-05 Thread mswit-databricks
Github user mswit-databricks commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r172142857 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -680,4 +681,31 @@ class JsonExpr

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r171375731 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -680,4 +681,31 @@ class JsonExpression

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-02-28 Thread mswit-databricks
GitHub user mswit-databricks opened a pull request: https://github.com/apache/spark/pull/20694 [SPARK-23173][SQL] Avoid creating corrupt parquet files when loading data from JSON ## What changes were proposed in this pull request? The from_json() function accepts an additio