[GitHub] spark pull request #20724: [SPARK-18630][PYTHON][ML] Move del method from Ja...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20724 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20724: [SPARK-18630][PYTHON][ML] Move del method from Ja...

2018-03-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20724#discussion_r172367567 --- Diff: python/pyspark/ml/tests.py --- @@ -173,6 +173,45 @@ class MockModel(MockTransformer, Model, HasFake): pass +class JavaWr

[GitHub] spark pull request #20724: [SPARK-18630][PYTHON][ML] Move del method from Ja...

2018-03-05 Thread yogeshg
Github user yogeshg commented on a diff in the pull request: https://github.com/apache/spark/pull/20724#discussion_r172273476 --- Diff: python/pyspark/ml/tests.py --- @@ -173,6 +173,45 @@ class MockModel(MockTransformer, Model, HasFake): pass +class JavaWrap

[GitHub] spark pull request #20724: [SPARK-18630][PYTHON][ML] Move del method from Ja...

2018-03-05 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20724#discussion_r172196812 --- Diff: python/pyspark/ml/tests.py --- @@ -173,6 +173,45 @@ class MockModel(MockTransformer, Model, HasFake): pass +class Jav

[GitHub] spark pull request #20724: [SPARK-18630][PYTHON][ML] Move del method from Ja...

2018-03-02 Thread yogeshg
GitHub user yogeshg opened a pull request: https://github.com/apache/spark/pull/20724 [SPARK-18630][PYTHON][ML] Move del method from JavaParams to JavaWrapper; add tests ## What changes were proposed in this pull request? Move del method from JavaParams to JavaWrapper; add