Github user makagonov closed the pull request at:
https://github.com/apache/spark/pull/20884
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20884#discussion_r176897510
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1229,7 +1229,7 @@ class JsonSuite extends Que
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20884#discussion_r176897268
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala
---
@@ -56,7 +56,7 @@ class JacksonGeneratorSuite
Github user makagonov commented on a diff in the pull request:
https://github.com/apache/spark/pull/20884#discussion_r176842732
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala
---
@@ -56,7 +56,7 @@ class JacksonGeneratorSuite ex
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20884#discussion_r176796998
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala
---
@@ -56,7 +56,7 @@ class JacksonGeneratorSuit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20884#discussion_r176715906
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala
---
@@ -56,7 +56,7 @@ class JacksonGeneratorSuite
GitHub user makagonov opened a pull request:
https://github.com/apache/spark/pull/20884
[SPARK-23773][SQL] JacksonGenerator does not include keys that have null
value for StructTypes
## What changes were proposed in this pull request?
As stated in Jira, when `toJSON` is called o