Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20980
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r183374541
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1255,8 +1255,64 @@ case class ExternalMapT
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r183374589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1255,8 +1255,64 @@ case class ExternalMapT
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r183373874
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -501,6 +502,111 @@ class ObjectExpre
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r183070120
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -472,6 +474,61 @@ class ObjectExpression
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r183036460
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -472,6 +474,61 @@ class ObjectExpres
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182945511
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -415,6 +417,36 @@ class ObjectExpression
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182933940
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1197,8 +1197,64 @@ case class ExternalMapToCat
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182930489
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -415,6 +417,36 @@ class ObjectExpression
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182734997
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
---
@@ -357,7 +357,8 @@ object JavaTypeInference {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182734666
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -415,6 +417,36 @@ class ObjectExpres
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r182734528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1197,8 +1197,64 @@ case class ExternalMapT
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r179355354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1176,8 +1176,28 @@ case class ExternalMapToCat
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r179349022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1176,8 +1176,28 @@ case class ExternalMapToCat
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20980
[SPARK-23589][SQL] ExternalMapToCatalyst should support interpreted
execution
## What changes were proposed in this pull request?
This pr supported interpreted mode for `ExternalMapToCatalyst`.
15 matches
Mail list logo