[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20986 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179897021 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java --- @@ -103,42 +106,27 @@ protected final void

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179867664 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java --- @@ -103,42 +106,27 @@ protected final void

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179645207 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala --- @@ -176,6 +141,23 @@ object

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179644816 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala --- @@ -176,6 +141,23 @@ object

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179644768 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala --- @@ -176,6 +141,23 @@ object

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179644530 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala --- @@ -286,23 +239,32 @@ object

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179525056 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala --- @@ -176,6 +141,23 @@ object

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179522607 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java --- @@ -103,42 +106,27 @@ protected final void

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179522408 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java --- @@ -156,6 +144,40 @@ public final void

[GitHub] spark pull request #20986: [SPARK-23864][SQL] Add unsafe object writing to U...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20986#discussion_r179522301 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java --- @@ -156,6 +144,40 @@ public final void