Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21021
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186076760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r18607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(ba
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186071434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186068983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186061995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(ba
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186060660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(ba
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186059899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(ba
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186040751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186042414
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186037573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +118,16 @@ case class MapValues(chi
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186037483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(ba
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186037447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(ba
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186002801
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(b
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186003960
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +118,16 @@ case class MapValues(ch
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186003272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(b
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r186002826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,191 @@ case class SortArray(b
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185378543
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,202 @@ case class SortArray(ba
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185197041
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,202 @@ case class SortArray(b
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185196808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,202 @@ case class SortArray(b
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185163397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray(b
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185166848
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray(b
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185163319
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray(b
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r185166899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,28 +161,205 @@ case class SortArray(b
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184632402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -185,6 +183,8 @@ trait ArraySortUtil extend
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184293071
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -185,6 +183,8 @@ trait ArraySortUtil exten
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184284276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray(bas
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -300,6 +333,49 @@ case class Reverse(child
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262594
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +118,18 @@ case class MapValues(ch
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262545
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray(ba
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261968
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -168,9 +140,9 @@ case class SortArray(base
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray(ba
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray(ba
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -191,24 +163,85 @@ case class SortArray(ba
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -168,9 +140,9 @@ case class SortArray(base
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184262129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +118,18 @@ case class MapValues(ch
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r184261947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -300,6 +333,49 @@ case class Reverse(child
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182999463
--- Diff: python/pyspark/sql/functions.py ---
@@ -2168,6 +2171,23 @@ def sort_array(col, asc=True):
return Column(sc._jvm.functions.sort_array(_to_ja
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182992892
--- Diff: python/pyspark/sql/functions.py ---
@@ -2154,10 +2154,13 @@ def array_max(col):
def sort_array(col, asc=True):
"""
Collection
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r18236
--- Diff: python/pyspark/sql/functions.py ---
@@ -2154,10 +2154,13 @@ def array_max(col):
def sort_array(col, asc=True):
"""
Collection
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182998415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -117,47 +117,18 @@ case class MapValues(ch
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r182993016
--- Diff: python/pyspark/sql/functions.py ---
@@ -2168,6 +2171,23 @@ def sort_array(col, asc=True):
return Column(sc._jvm.functions.sort_array(_to_ja
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180429349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +161,118 @@ case class SortArray(ba
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180400407
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +161,118 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180392603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +161,118 @@ case class SortArray(ba
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180384110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +161,118 @@ case class SortArray
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180319251
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortArray(ba
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180318978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortArray(b
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180317825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortArray(ba
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180317210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortArray(ba
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180316279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortArray(b
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180312180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortAr
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180311923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortAr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180311343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortArray(ba
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180310842
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -324,6 +324,30 @@ class DataFrameFunctionsSuite extends Quer
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180310741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -190,28 +160,114 @@ case class SortAr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21021#discussion_r180310339
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -116,47 +116,17 @@ case class MapValues(chi
57 matches
Mail list logo
