[GitHub] spark pull request #21194: [SPARK-24046][SS] Fix rate source when rowsPerSec...

2018-05-03 Thread maasg
Github user maasg commented on a diff in the pull request: https://github.com/apache/spark/pull/21194#discussion_r185891712 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala --- @@ -173,55 +173,154 @@ class RateSourceS

[GitHub] spark pull request #21194: [SPARK-24046][SS] Fix rate source when rowsPerSec...

2018-05-03 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21194#discussion_r185851172 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala --- @@ -173,55 +173,154 @@ class Rate

[GitHub] spark pull request #21194: [SPARK-24046][SS] Fix rate source when rowsPerSec...

2018-05-01 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21194#discussion_r185252544 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProvider.scala --- @@ -101,25 +101,10 @@ object RateStrea

[GitHub] spark pull request #21194: [SPARK-24046][SS] Fix rate source when rowsPerSec...

2018-05-01 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21194#discussion_r185252360 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProvider.scala --- @@ -101,25 +101,10 @@ object RateStrea

[GitHub] spark pull request #21194: [SPARK-24046][SS] Fix rate source when rowsPerSec...

2018-04-30 Thread maasg
GitHub user maasg opened a pull request: https://github.com/apache/spark/pull/21194 [SPARK-24046][SS] Fix rate source when rowsPerSecond <= rampUpTime ## What changes were proposed in this pull request? Fixes the ramp-up of the rate source for the case `rowsPerSecond <= r