Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21276
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r194630048
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2715,6 +2716,62 @@ private[spark] object Utils extends Logging {
HashCodes.fr
Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187540911
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {
HashCodes.
Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187540472
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1168,6 +1168,35 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProp
Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187540452
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {
HashCodes.
Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187518454
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {
HashCodes.
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187282260
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {
HashCodes.fr
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187279829
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1168,6 +1168,35 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProper
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187278875
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {
HashCodes.fr
Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187271712
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1168,6 +1168,32 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProp
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187264126
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1168,6 +1168,32 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProper
Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187263297
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -109,7 +110,8 @@ trait TypedAggregateExpr
Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187263253
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1168,6 +1168,23 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProp
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r186984569
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1168,6 +1168,23 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProper
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r186983813
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -109,7 +110,8 @@ trait TypedAggregateExpres
GitHub user fangshil opened a pull request:
https://github.com/apache/spark/pull/21276
[SPARK-24216][SQL] Spark TypedAggregateExpression uses getSimpleName that
is not safe in scala
## What changes were proposed in this pull request?
When we create a aggregator object withi
16 matches
Mail list logo
