[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-07-18 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r203561847 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala --- @@ -115,7 +116,7 @@ private[kafka010] class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-07-17 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r203256766 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala --- @@ -115,7 +116,7 @@ private[kafka010] class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-07-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r203109788 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala --- @@ -115,7 +116,7 @@ private[kafka010] class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-07-17 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r203106522 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala --- @@ -115,7 +116,7 @@ private[kafka010] class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-07-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r203104176 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala --- @@ -115,7 +116,7 @@ private[kafka010] class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-07-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r203103522 --- Diff: external/kafka-0-10-sql/pom.xml --- @@ -74,6 +74,11 @@ ${kafka.version} test + +

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-06 Thread guozhangwang
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r193574097 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -203,7 +215,13 @@ class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-06 Thread eric-maynard
Github user eric-maynard commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r193549547 --- Diff: external/kafka-0-10-sql/pom.xml --- @@ -29,7 +29,7 @@ spark-sql-kafka-0-10_2.11 sql-kafka-0-10 -0.10.0.1

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-05 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r192961847 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -203,7 +215,13 @@ class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-03 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r192602632 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -96,10 +101,13 @@ class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-03 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r192601997 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -96,10 +101,13 @@ class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-03 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r192601219 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala --- @@ -96,10 +101,13 @@ class

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-06-03 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/spark/pull/21488 SPARK-18057 Update structured streaming kafka from 0.10.0.1 to 2.0.0 ## What changes were proposed in this pull request? This PR upgrades to the Kafka 2.0.0 release where KIP-266 is