[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196247811 --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala --- @@ -109,20 +116,21 @@ private[spark] class

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196247047 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -399,7 +399,8 @@ private[spark] object JsonProtocol { ("Full Stack

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196246952 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -399,7 +399,8 @@ private[spark] object JsonProtocol { ("Full Stack

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196246754 --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala --- @@ -131,16 +139,17 @@ private[spark] class

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196246700 --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala --- @@ -131,16 +139,17 @@ private[spark] class

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196235040 --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala --- @@ -109,20 +116,21 @@ private[spark] class

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196217742 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -399,7 +399,8 @@ private[spark] object JsonProtocol { ("Full Stack

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196215961 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -399,7 +399,8 @@ private[spark] object JsonProtocol { ("Full Stack

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196214944 --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala --- @@ -131,16 +139,17 @@ private[spark] class

[GitHub] spark pull request #21577: [SPARK-24552][core] Correctly identify tasks in o...

2018-06-18 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21577#discussion_r196214788 --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala --- @@ -131,16 +139,17 @@ private[spark] class